WebSVN – SvarDOS – Diff – /buildidx/buildidx.php

 <?php /*
   SvarDOS repo index builder
   Copyright (C) Mateusz Viste 2012-2022
   buildidx computes an index json file for the SvarDOS repository.
   it must be executed pointing to a directory that stores packages (*.svp)
   files. buildidx will generate the index file and save it into the package
   repository.
   requires php-zip
-feb 2022: buildidx collects categories looking at the dir layout of each package
+feb 2022: buildidx collects categories looking at the dir layout of each package + improved version string parsing (replaced version_compare call by dos_version_compare)
 feb 2022: checking for non-8+3 filenames in packages and duplicates + devload no longer part of CORE
 feb 2022: added warning about overlong version strings and wild files location
 feb 2022: index is generated as json, contains all filenames and alt versions
 feb 2022: packages are expected to have the *.svp extension
 feb 2022: skip source packages from being processed (*.src.zip)
 jan 2022: rewritten the code from ANSI C to PHP for easier maintenance
 feb 2021: 'title' LSM field is no longer looked after
 feb 2021: lsm headers are no longer checked, so it is compatible with the simpler lsm format used by SvarDOS
 jan 2021: removed the identification line, changed CRC32 to bsum, not creating the listing.txt file and stopped compressing index
 apr 2017: uncompressed index is no longer created, added CRC32 of zib (bin only) files, if present
 aug 2016: listing.txt is always written inside the repo dir (instead of inside current dir)
 aug 2016: accepting full paths to repos (starting with /...)
 dec 2013: rewritten buildidx in ANSI C89
 aug 2013: add a compressed version of the index file to repos (index.gz)
 jul 2013: creating a listing.txt file with list of packages
 jul 2013: writing the number of packaged into the first line of the lst file
 jul 2013: added a switch to 7za to make it case insensitive when extracting lsm files
 jul 2013: changed unzip calls to 7za (to handle cases when appinfo is compressed with lzma)
 feb 2013: added CRC32 support
 sep 2012: forked 1st version from FDUPDATE builder
 */
 $PVER = "20220221";
 // computes the BSD sum of a file and returns it
 function file2bsum($fname) {
   $result = 0;
   $fd = fopen($fname, 'rb');
   if ($fd === false) return(0);
   while (!feof($fd)) {
     $buff = fread($fd, 1024 * 1024);
     $slen = strlen($buff);
     for ($i = 0; $i < $slen; $i++) {
       // rotr
       $result = ($result >> 1) | ($result << 15);
       // add and truncate to 16 bits
       $result += ord($buff[$i]);
       $result &= 0xffff;
+    }
+  }
   fclose($fd);
   return($result);
+}
+// translates a version string into a array of integer values.
+// Accepted formats follow:
+//    300.12.1
+//    1
+//    12.2.34.2-4.5
+//    1.2c
+//    1.01 beta+3
+//    2013-12-31
+//    20220222 alpha
+function vertoarr($verstr) {
+  $subver = array(0,0,0,0);
+  // switch string to lcase for easier processing and trim any leading or trailing white spaces
+  $verstr = strtolower(trim($verstr));
+  // replace all '-' and '/' characters to '.' (uniformization of sub-version parts delimiters)
+  $verstr = strtr($verstr, '-/', '..');
+  // is there a subversion value? (for example "+4" in "1.05+4")
+  $i = strrpos($verstr, '+', 1);
+  if ($i !== false) {
+    // validate the svar-version is a proper integer
+    $svarver = substr($verstr, $i + 1);
+    if (! preg_match('/[1-9][0-9]*/', $svarver)) {
+      return(false);
+    }
+    $subver[3] = intval($svarver); // set the +rev as a very minor item
+    $verstr = substr($verstr, 0, $i);
+  }
+  // is the version ending with ' alpha', 'beta'?
+  if (preg_match('/ (alpha|beta)$/', $verstr)) {
+    $i = strrpos($verstr, ' ');
+    $greek = substr($verstr, $i + 1);
+    $verstr = trim(substr($verstr, 0, $i));
+    if ($greek == 'alpha') {
+      $subver[2] = 1;
+    } else if ($greek == 'beta') {
+      $subver[2] = 2;
+    } else {
+      return(false);
+    }
+  }
+  // does the version string have a single-letter subversion? (1.0c)
+  if (preg_match('/[a-z]$/', $verstr)) {
+    $subver[1] = ord(substr($verstr, -1));
+    $verstr = substr_replace($verstr, '', -1); // remove last character from string
+  }
+  // validate the format is supported, should be something no more complex than 1.05.3.33
+  if (! preg_match('/[0-9][0-9.]{0,20}/', $verstr)) {
+    return(false);
+  }
+  // NOTE: a zero right after a separator and trailed with a digit (as in 1.01)
+  //       has a special meaning
+  $exploded = explode('.', $verstr);
+  if (count($exploded) > 16) {
+    return(false);
+  }
+  $exploded[16] = $subver[0]; // unused yet
+  $exploded[17] = $subver[1]; // a-z (1.0c)
+  $exploded[18] = $subver[2]; // alpha/beta
+  $exploded[19] = $subver[3]; // svar-ver (1.0+5)
+  for ($i = 0; $i < 20; $i++) if (empty($exploded[$i])) $exploded[$i] = '0';
+  ksort($exploded);
+  return($exploded);
+}
+function dos_version_compare($v1, $v2) {
+  $v1arr = vertoarr($v1);
+  $v2arr = vertoarr($v2);
+  for ($i = 0; $i < count($v1arr); $i++) {
+    $r = strcmp($v1arr[$i], $v2arr[$i]);
+    if ($r != 0) return($r);
+  }
+  return(0);
+}
 // reads file fil from zip archive z and returns its content, or false on error
 function read_file_from_zip($z, $fil) {
   $zip = new ZipArchive;
   if ($zip->open($z, ZipArchive::RDONLY) !== true) {
     echo "ERROR: failed to open zip file '{$z}'\n";
     return(false);
+  }
   // load the appinfo/pkgname.lsm file
   $res = $zip->getFromName($fil, 8192, ZipArchive::FL_NOCASE);
   $zip->close();
   return($res);
+}
 function read_list_of_files_in_zip($z) {
   $zip = new ZipArchive;
   if ($zip->open($z, ZipArchive::RDONLY) !== true) {
     echo "ERROR: failed to open zip file '{$z}'\n";
     return(false);
+  }
   $res = array();
   for ($i = 0; $i < $zip->numFiles; $i++) $res[] = $zip->getNameIndex($i);
   $zip->close();
   return($res);
+}
 // reads a LSM string and returns it in the form of an array
 function parse_lsm($s) {
   $res = array();
   for ($l = strtok($s, "\n"); $l !== false; $l = strtok("\n")) {
     // the line is "token: value", let's find the colon
     $colpos = strpos($l, ':');
     if (($colpos === false) || ($colpos === 0)) continue;
     $tok = strtolower(trim(substr($l, 0, $colpos)));
     $val = trim(substr($l, $colpos + 1));
     $res[$tok] = $val;
+  }
   return($res);
+}
 // on PHP 8+ there is str_starts_with(), but not on PHP 7 so I use this
 function str_head_is($haystack, $needle) {
   return strpos($haystack, $needle) === 0;
+}
 // returns an array that contains CORE packages (populated from the core subdirectory in pkgdir)
 function load_core_list($repodir) {
   $res = array();
   foreach (scandir($repodir . '/core/') as $f) {
     if (!preg_match('/\.svp$/', $f)) continue;
     $res[] = explode('.', $f)[0];
+  }
   return($res);
+}
 // ***************** MAIN ROUTINE *********************************************
 //echo "SvarDOS repository index generator ver {$PVER}\n";
 if (($_SERVER['argc'] != 2) || ($_SERVER['argv'][1][0] == '-')) {
   echo "usage: php buildidx.php repodir\n";
   exit(1);
+}
 $repodir = $_SERVER['argv'][1];
 $pkgfiles = scandir($repodir);
 $pkgcount = 0;
 // load the list of CORE and MSDOS_COMPAT packages
 $core_packages_list = load_core_list($repodir);
 $msdos_compat_list = explode(' ', 'append assign attrib chkdsk choice command comp cpidos debug defrag deltree diskcomp diskcopy display edit edlin exe2bin fc fdapm fdisk find format help himemx kernel keyb label localcfg mem mirror mode more move nlsfunc print replace share shsucdx sort swsubst tree undelete unformat xcopy');
 // do a list of all svp packages with their available versions and descriptions
 $pkgdb = array();
 foreach ($pkgfiles as $fname) {
   if (!preg_match('/\.svp$/i', $fname)) continue; // skip non-svp files
   if (!preg_match('/^[a-zA-Z0-9+. _-]*\.svp$/', $fname)) {
     echo "ERROR: {$fname} has a very weird name\n";
     continue;
+  }
   $path_parts = pathinfo($fname);
   $pkgnam = explode('-', $path_parts['filename'])[0];
   $pkgfullpath = realpath($repodir . '/' . $fname);
   $lsm = read_file_from_zip($pkgfullpath, "appinfo/{$pkgnam}.lsm");
   if ($lsm == false) {
     echo "ERROR: {$fname} does not contain an LSM file at the expected location\n";
     continue;
+  }
   $lsmarray = parse_lsm($lsm);
   if (empty($lsmarray['version'])) {
     echo "ERROR: lsm file in {$fname} does not contain a version\n";
     continue;
+  }
   if (strlen($lsmarray['version']) > 16) {
     echo "ERROR: version string in lsm file of {$fname} is too long (16 chars max)\n";
     continue;
+  }
   if (empty($lsmarray['description'])) {
     echo "ERROR: lsm file in {$fname} does not contain a description\n";
     continue;
+  }
   // validate the files present in the archive
   $listoffiles = read_list_of_files_in_zip($pkgfullpath);
   $pkgdir = $pkgnam;
   // special rule for "parent and children" packages
   if (str_head_is($pkgnam, 'djgpp_')) $pkgdir = 'djgpp'; // djgpp_* packages put their files in djgpp
   if ($pkgnam == 'fbc_help') $pkgdir = 'fbc'; // FreeBASIC help goes to the FreeBASIC dir
   if ($pkgnam == 'clamdb') $pkgdir = 'clamav'; // data patterns for clamav
   // array used to detect duplicated entries after lower-case conversion
   $duparr = array();
   // will hold the list of categories that this package belongs to
   $catlist = array();
   foreach ($listoffiles as $f) {
     $f = strtolower($f);
     $path_array = explode('/', $f);
     // emit a warning when non-8+3 filenames are spotted and find duplicates
     foreach ($path_array as $item) {
       if (empty($item)) continue; // skip empty items at end of paths (eg. appinfo/)
       if (!preg_match("/[a-z0-9!#$%&'()@^_`{}~-]{1,8}(\.[a-z0-9!#$%&'()@^_`{}~-]{1,3}){0,1}/", $item)) {
         echo "WARNING: {$fname} contains a non-8+3 path (or weird char): {$item} (in $f)\n";
+      }
+    }
     // look for dups
     if (array_search($f, $duparr) !== false) {
       echo "WARNING: {$fname} contains a duplicated entry: '{$f}'\n";
     } else {
       $duparr[] = $f;
+    }
     // LSM file is ok
     if ($f === "appinfo/{$pkgnam}.lsm") continue;
     if ($f === "appinfo/") continue;
     // CORE and MSDOS_COMPAT packages are premium citizens and can do a little more
     $core_or_msdoscompat = 0;
     if (array_search($pkgnam, $core_packages_list) !== false) {
       $catlist[] = 'core';
       $core_or_msdoscompat = 1;
+    }
     if (array_search($pkgnam, $msdos_compat_list) !== false) {
       $catlist[] = 'msdos_compat';
       $core_or_msdoscompat = 1;
+    }
     if ($core_or_msdoscompat == 1) {
       if (str_head_is($f, 'bin/')) continue;
       if (str_head_is($f, 'cpi/')) continue;
       if (str_head_is($f, "doc/{$pkgdir}/")) continue;
       if ($f === 'doc/') continue;
       if (str_head_is($f, "nls/{$pkgdir}.")) continue;
       if ($f === 'nls/') continue;
+    }
     // the help package is allowed to put files in... help
     if (($pkgnam == 'help') && (str_head_is($f, 'help/'))) continue;
     // must be category-prefixed file, add it to the list of categories for this package
     $catlist[] = explode('/', $f)[0];
     // well-known "category" dirs are okay
     if (str_head_is($f, "progs/{$pkgdir}/")) continue;
     if ($f === 'progs/') continue;
     if (str_head_is($f, "devel/{$pkgdir}/")) continue;
     if ($f === 'devel/') continue;
     if (str_head_is($f, "games/{$pkgdir}/")) continue;
     if ($f === 'games/') continue;
     if (str_head_is($f, "drivers/{$pkgdir}/")) continue;
     if ($f === 'drivers/') continue;
     echo "WARNING: {$fname} contains a file in an illegal location: {$f}\n";
+  }
+  // do I understand the version string?
+  if (vertoarr($lsmarray['version']) === false) echo "WARNING: {$fname} parsing of version string failed ('{$lsmarray['version']}')\n";
   $meta['fname'] = $fname;
   $meta['desc'] = $lsmarray['description'];
   $meta['cats'] = array_unique($catlist);
   $pkgdb[$pkgnam][$lsmarray['version']] = $meta;
+}
 $db = array();
 $cats = array();
 // ******** compute the version-sorted list of packages with a single *********
 // ******** description and category list for each package ********************
 // iterate over each svp package
 foreach ($pkgdb as $pkg => $versions) {
   // sort filenames by version, highest first
-  uksort($versions, "version_compare");
+  uksort($versions, "dos_version_compare");
   $versions = array_reverse($versions, true);
   foreach ($versions as $ver => $meta) {
     $fname = $meta['fname'];
     $desc = $meta['desc'];
     $bsum = file2bsum(realpath($repodir . '/' . $fname));
     $meta2['ver'] = strval($ver);
     $meta2['bsum'] = $bsum;
     if (empty($db[$pkg]['desc'])) $db[$pkg]['desc'] = $desc;
     if (empty($db[$pkg]['cats'])) {
       $db[$pkg]['cats'] = $meta['cats'];
       $cats = array_unique(array_merge($cats, $meta['cats']));
+    }
     $db[$pkg]['versions'][$fname] = $meta2;
+  }
   $pkgcount++;
+}
 if ($pkgcount < 100) echo "WARNING: an unexpectedly low number of packages has been found in the repo ({$pkgcount})\n";
 $json_blob = json_encode($db);
 if ($json_blob === false) {
   echo "ERROR: JSON convertion failed! -> ";
   switch (json_last_error()) {
     case JSON_ERROR_DEPTH:
       echo 'maximum stack depth exceeded';
       break;
     case JSON_ERROR_STATE_MISMATCH:
       echo 'underflow of the modes mismatch';
       break;
     case JSON_ERROR_CTRL_CHAR:
       echo 'unexpected control character found';
       break;
     case JSON_ERROR_UTF8:
       echo 'malformed utf-8 characters';
       break;
     default:
       echo "unknown error";
       break;
+  }
   echo "\n";
+}
 file_put_contents($repodir . '/_index.json', $json_blob);
 $cats_json = json_encode($cats);
 file_put_contents($repodir . '/_cats.json', $cats_json);
 exit(0);
 ?>

Subversion Repositories SvarDOS

(root)/buildidx/buildidx.php – Rev 909 → 912